> On March 23, 2016, 6:49 p.m., Ben Mahler wrote: > > src/tests/master_validation_tests.cpp, lines 1175-1176 > > <https://reviews.apache.org/r/44854/diff/4/?file=1310574#file1310574line1175> > > > > Why the explicit detector?
After recent test harness refactoring, there is no `StartSlave()` overload creating detector implicitly. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/#review125090 ----------------------------------------------------------- On March 22, 2016, 5:05 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44854/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 5:05 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4949 > https://issues.apache.org/jira/browse/MESOS-4949 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca > src/tests/master_validation_tests.cpp > 8d0070a1b8e8dcc7fe6360f8c6c6182ba9edef7d > > Diff: https://reviews.apache.org/r/44854/diff/ > > > Testing > ------- > > On Mac OS 10.10.4: > `make check` > `GTEST_FILTER="TaskValidationTest.ExecutorShutdownGracePeriodIsNonNegative" > ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure` > > > Thanks, > > Alexander Rukletsov > >
