----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44435/#review124251 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp (line 674) <https://reviews.apache.org/r/44435/#comment186705> Thanks for catching the bug. I think this is a pretty bad bug which might worth cutting 0.28.1. Your fix for this issue does reveal another issue in the code: It's possible that we will call provisioner->destroy while provisioner->provision is in progress. This could cause leaking of the provisioned directory. I'll create another ticket for that. Can you add a TODO here? For this patch, can you add a comment here stating why you need to set it to be a ready future here? E.g.: ``` We need to set the 'launchInfos' to be a ready future initially before we starting calling isolator->prepare() because otherwise, the destroy will wait forever trying to wait for this future to be ready, which it never will. ``` src/tests/containerizer/mesos_containerizer_tests.cpp (line 776) <https://reviews.apache.org/r/44435/#comment186708> Can you use a UUID::random() here? src/tests/containerizer/mesos_containerizer_tests.cpp (line 819) <https://reviews.apache.org/r/44435/#comment186710> This is not accurate. We need to improve that. Can you add a TODO here. I think we should introduce a new state PROVISIONING. - Jie Yu On March 6, 2016, 9:23 p.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44435/ > ----------------------------------------------------------- > > (Updated March 6, 2016, 9:23 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4878 > https://issues.apache.org/jira/browse/MESOS-4878 > > > Repository: mesos > > > Description > ------- > > Fixed a bug that causes the task stuck in staging state. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > af3ff5750649497d8852b4761c78d4cae5455a02 > src/tests/containerizer/mesos_containerizer_tests.cpp > 15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 > > Diff: https://reviews.apache.org/r/44435/diff/ > > > Testing > ------- > > - Added a new test `"MesosContainerizerProvisionerTest.ProvisionFailed"` > - make check > > > Thanks, > > Shuai Lin > >
