----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44435/#review124145 -----------------------------------------------------------
Fix it, then Ship it! Ship It! src/tests/containerizer/mesos_containerizer_tests.cpp (line 798) <https://reviews.apache.org/r/44435/#comment186535> Should we `AWAIT_FAILED(launch)` return by `.launch` here? Because `provisioner->provision` return `Failure`. - haosdent huang On March 6, 2016, 9:23 p.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44435/ > ----------------------------------------------------------- > > (Updated March 6, 2016, 9:23 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4878 > https://issues.apache.org/jira/browse/MESOS-4878 > > > Repository: mesos > > > Description > ------- > > Fixed a bug that causes the task stuck in staging state. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > af3ff5750649497d8852b4761c78d4cae5455a02 > src/tests/containerizer/mesos_containerizer_tests.cpp > 15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 > > Diff: https://reviews.apache.org/r/44435/diff/ > > > Testing > ------- > > - Added a new test `"MesosContainerizerProvisionerTest.ProvisionFailed"` > - make check > > > Thanks, > > Shuai Lin > >