----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/#review124350 -----------------------------------------------------------
src/master/http.cpp (line 958) <https://reviews.apache.org/r/45000/#comment186833> According to the rules defined in https://tools.ietf.org/html/rfc3986#section-5 we should be fine to use a scheme relative location. I think keeping the link to the RFC is a good idea here, so that the next person that reads this code knows explicitly what this code was written against. - Ben Whitehead On March 17, 2016, 5:04 p.m., Ashwin Murthy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45000/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 5:04 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > MESOS-3902: Fix in location header during redirect from non-leader. The fix > is to add the scheme and path to the URL in the location header. Previously, > we did not have the scheme and path. We need to update the mesos http API > documentation section on master redirect to reflect this change. > > > Diffs > ----- > > src/master/http.cpp b47ab7cc86c0a56a81815a98bd63f37a1175ba7f > > Diff: https://reviews.apache.org/r/45000/diff/ > > > Testing > ------- > > Was trying to write unit test in scheduler http api test but it turns out > multi master tests cannot be written at this point. Need to manually verify > this by setting up multiple masters with ZK. > > > Thanks, > > Ashwin Murthy > >
