----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/#review124472 -----------------------------------------------------------
Can you confirm that you did a manual test of this (using curl and multiple masters w/ ZK)? src/master/http.cpp (lines 970 - 972) <https://reviews.apache.org/r/45000/#comment187041> looks like this fits in one line, why the wrapping? ``` return TemporaryRedirect( "//" + hostname.get() + ":" + stringify(info.port()) + request.url.path); ``` - Vinod Kone On March 20, 2016, 11:03 p.m., Ashwin Murthy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45000/ > ----------------------------------------------------------- > > (Updated March 20, 2016, 11:03 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > MESOS-3902: [Updated] Fix location header in redirect from non-leader. > Addressed comments from Vinod and Ben. Removed the scheme but added the path > from the original request to the location header. Preserved the link to the > RFC in the comments. > > > Diffs > ----- > > src/master/http.cpp bfea8fa811c24d37b2d7a8109728e1f40217e02f > > Diff: https://reviews.apache.org/r/45000/diff/ > > > Testing > ------- > > Was trying to write unit test in scheduler http api test but it turns out > multi master tests cannot be written at this point. Need to manually verify > this by setting up multiple masters with ZK. > > > Thanks, > > Ashwin Murthy > >
