> On March 18, 2016, 7:08 p.m., haosdent huang wrote:
> > support/non-ascii.py, line 47
> > <https://reviews.apache.org/r/45033/diff/1/?file=1305279#file1305279line47>
> >
> > Is it possible to print the match test as well? Sometimes find the
> > invalid char in a long line is not easy.
I added a position ("Pos") in addition to the line number. Printing out the
exact character is fairly complicated. We can certainly print out the hex value
like 0x0A, 0x80, etc. but that will not be too helpful. On the other hand,
since some of the characters are just invalide characters (not necessarily
unicode strings) so it may not be printable anyway. I think combining line
number with the position should be OK to figure out the place to make
adjustment.
- Yong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review124256
-----------------------------------------------------------
On March 18, 2016, 11:11 p.m., Yong Tang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45033/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 11:11 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and haosdent
> huang.
>
>
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This review request tries to add a commit hook for checking non-ascii
> characters. It scans .cpp, .hpp, .cc, .h, and .md files and report
> error if non-ascii characters exists.
>
> As part of this review request, two non-ascii characters are identified
> in versioning.md (one in Ln 85 and another in Ln 96) and are corrected
> accordingly.
>
>
> Diffs
> -----
>
> docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b
> support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453
> support/non-ascii.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45033/diff/
>
>
> Testing
> -------
>
> Tested manually and found two non ascii characters in docs/versioning.md
> (fixed as part of this review request).
>
>
> Thanks,
>
> Yong Tang
>
>
