----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124253 -----------------------------------------------------------
docs/versioning.md (line 85) <https://reviews.apache.org/r/45033/#comment186709> Any reason we need change here? support/non-ascii.py (line 21) <https://reviews.apache.org/r/45033/#comment186712> Seems we have to update this when we update third part dependencies every time? For example, if we update protobuf to 2.6, this rule need update as well. Is it possible to avoid this? - haosdent huang On March 18, 2016, 2:48 p.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 2:48 p.m.) > > > Review request for mesos, Alexander Rukletsov and Bernd Mathiske. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > ------- > > This review request tries to add a commit hook for checking non-ascii > characters. It scans .cpp, .hpp, .cc, .h, and .md files and report > error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > > Diffs > ----- > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 > support/non-ascii.py PRE-CREATION > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > ------- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
