----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/#review123974 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/network/cni/spec.proto (lines 55 - 59) <https://reviews.apache.org/r/44622/#comment186323> Let's move this to the top level: https://github.com/appc/cni/blob/master/pkg/types/types.go#L94 Also, rename it to IPConfig like above. - Jie Yu On March 16, 2016, 7:58 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44622/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 7:58 a.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Introduced a protobuf message "NetworkResult". > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto PRE-CREATION > > Diff: https://reviews.apache.org/r/44622/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
