> On March 18, 2016, 7:50 p.m., Kevin Klues wrote: > > src/linux/cgroups.cpp, lines 2663-2697 > > <https://reviews.apache.org/r/44974/diff/2/?file=1305100#file1305100line2663> > > > > These will go away.
Whoops! grabbed too much context there. Only the constrtuctor shoudl go away, not the `list()` call. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/#review124265 ----------------------------------------------------------- On March 18, 2016, 9:41 a.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44974/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 9:41 a.m.) > > > Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and > Niklas Nielsen. > > > Bugs: MESOS-3368 > https://issues.apache.org/jira/browse/MESOS-3368 > > > Repository: mesos > > > Description > ------- > > There are some helper methods added to support device cgroups in cgroups > abstraction to aid isolators controlling access to devices. > > > Diffs > ----- > > src/linux/cgroups.hpp 51ccefd1fd2d0989b9bd31342d3d1e3701f88ed2 > src/linux/cgroups.cpp df18ed46a2a96871f67c7eb4233c3b4c27b7aa1c > > Diff: https://reviews.apache.org/r/44974/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Abhishek Dasgupta > >