----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/#review124093 -----------------------------------------------------------
For reference, Ahishek and I talked offline, and he modified his review based off of a branch I pushed out to github: https://github.com/klueska-mesosphere/mesos/commits/r/a10gupta/cgroups-devices The old reviews that this review is based on are: https://reviews.apache.org/r/44439/ https://reviews.apache.org/r/44796/ - Kevin Klues On March 17, 2016, 7:21 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44974/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 7:21 p.m.) > > > Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and > Niklas Nielsen. > > > Bugs: MESOS-3368 > https://issues.apache.org/jira/browse/MESOS-3368 > > > Repository: mesos > > > Description > ------- > > There are some helper methods added to support device cgroups in cgroups > abstraction to aid isolators controlling access to devices. > > > Diffs > ----- > > src/linux/cgroups.hpp 51ccefd1fd2d0989b9bd31342d3d1e3701f88ed2 > src/linux/cgroups.cpp df18ed46a2a96871f67c7eb4233c3b4c27b7aa1c > > Diff: https://reviews.apache.org/r/44974/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Abhishek Dasgupta > >
