-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45046/
-----------------------------------------------------------
(Updated March 21, 2016, 12:49 a.m.)
Review request for mesos, Vinod Kone and Zhitao Li.
Changes
-------
Address comments and add API changes to CHANGELOG.
Bugs: MESOS-4735
https://issues.apache.org/jira/browse/MESOS-4735
Repository: mesos
Description
-------
Created URI.filename to name fetched files in sandbox where appropriate.
Diffs (updated)
-----
3rdparty/libprocess/include/process/help.hpp
3f859803f3096d3161fffb6485ce1ce3cb6b04bc
3rdparty/libprocess/src/help.cpp e046933975883fb046af8e51c31a742d983a6321
3rdparty/libprocess/src/logging.cpp bdbf716ee46a459f1004f0f4b72c23aae135f347
CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6
docs/endpoints/master/api/v1/scheduler.md
538979977e07b484956be85b08b0dbc6cffcef01
docs/endpoints/master/create-volumes.md
52ae3a8159bb7d26b63f5889ce3f122371afbdc4
docs/endpoints/master/destroy-volumes.md
a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff
docs/endpoints/master/flags.md e9038fece0d17432f839c1719beac65d1a351550
docs/endpoints/master/frameworks.md 15ecabfdd87faee6a1f24895088a3c08edf62b96
docs/endpoints/master/health.md dc1c1cd6f78874b9264279dd78c57aa572d048a4
docs/endpoints/master/machine/down.md
f7e81417aa663e287a61124b351f2461b1c106e6
docs/endpoints/master/machine/up.md d96be726f5cf524937e3ebc5b046bf5f47886a1c
docs/endpoints/master/maintenance/schedule.md
577e43c5faa961acb75f66e0db6729d7db9d88bf
docs/endpoints/master/maintenance/status.md
249dae2706ccf30d79e0cd2f19821acd6ada74b7
docs/endpoints/master/observe.md 9ebd527788bbd2fd2dd833242c24ac561f826c30
docs/endpoints/master/quota.md b1e3462bd35c5acfd65323db5d0660277b110b11
docs/endpoints/master/redirect.md 833d9935b8fb038977fe08d826d73f03f2059bab
docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c
docs/endpoints/master/roles.json.md 01e265330c4c30de11301a2c4abbddfee10ac35d
docs/endpoints/master/roles.md 9c01d370a86d77eb95fcc157de70304e73f5f1e9
docs/endpoints/master/slaves.md 9e9fff7329d6bf05ae78997b1292657ff4dd10c3
docs/endpoints/master/state-summary.md
a0da400b34c202602cb661a19c6199291da4ff4b
docs/endpoints/master/state.json.md 7998b80f29042f4b67565b03e2464b6e3a009335
docs/endpoints/master/state.md 59518d624a0c5e010f856c900a9d6512a35b21af
docs/endpoints/master/tasks.json.md 29bb9738b1519174eaeac4f4db423000fe48d0d3
docs/endpoints/master/tasks.md ab9bb09631400668adddeee363dd612c71e98e16
docs/endpoints/master/teardown.md 9b62b2656162b4160a9845152aecf7b75231fbae
docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103
docs/endpoints/master/weights.md 7c4517343aa61bf6156fa54547690930051616a3
docs/fetcher.md f70939d8410516c9387a8cba86b5b75539a5fe9a
include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b
include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b
src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c
src/executor/executor.cpp 48b00504cac83aa0f4b1fc0b81480d3010edebae
src/launcher/executor.cpp 63eb8f1ae5510acdb5b504807a37c4e2e68ad6bd
src/launcher/fetcher.cpp f85b118fb19cf9d4563f89847a783be35067e815
src/master/http.cpp bfea8fa811c24d37b2d7a8109728e1f40217e02f
src/slave/containerizer/fetcher.hpp bbdce88da6e41dbb88681bc9d604b00923033b3d
src/slave/containerizer/fetcher.cpp 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161
src/slave/containerizer/mesos/containerizer.cpp
ee7a265975323ca891114a286357c8e42901560c
src/slave/http.cpp 0117827d73bd1b4c96ef261d4573abf70f52c6b3
src/tests/containerizer/mesos_containerizer_tests.cpp
f3ca32b2d8b8ef9dcfa8f20d9ceaff48b6598a66
src/tests/fetcher_cache_tests.cpp 645dae208cb2b0aa2d2181d96eb1fd8893975430
src/tests/fetcher_tests.cpp fb47706eb90ae5808bafe13c681d609a808b0c8e
Diff: https://reviews.apache.org/r/45046/diff/
Testing
-------
There are two paths by which a file gets fetched to the executor sandbox: the
without-cache path, where the fetcher downloads the file directly from the
specified URI, and the with-cache path, where it copies it from the cache. In
both cases, we verify that the file is saved to the sandbox directory with the
name specified by the "filename" field in the CommandInfo.URI proto.
Thanks,
Michael Browning
