----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/#review124480 -----------------------------------------------------------
src/tests/fetcher_tests.cpp (line 646) <https://reviews.apache.org/r/45046/#comment187054> s/fix/Fix/ Also, instead of here this TODO should be located at tests that do os::mktemp() (e.g., #431). src/tests/fetcher_tests.cpp (line 648) <https://reviews.apache.org/r/45046/#comment187055> why is this directory named "cutom_gzip_filename" ? also you are calling mkdtemp() but not using 'XXX' pattern? if you want to a well known directory name you can as well just use os::mkdir(). src/tests/fetcher_tests.cpp (line 651) <https://reviews.apache.org/r/45046/#comment187056> ditto. this should be os::touch() if you want a well known filename. src/tests/fetcher_tests.cpp (line 687) <https://reviews.apache.org/r/45046/#comment187057> ditto. see above. src/tests/fetcher_tests.cpp (lines 688 - 692) <https://reviews.apache.org/r/45046/#comment187058> ditto. see above. CHANGELOG (line 1) <https://reviews.apache.org/r/45046/#comment187059> s/0.29.0/0.29.0 (WIP)/ CHANGELOG (line 7) <https://reviews.apache.org/r/45046/#comment187060> 2 blank lines. - Vinod Kone On March 21, 2016, 12:51 a.m., Michael Browning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45046/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 12:51 a.m.) > > > Review request for mesos, Vinod Kone and Zhitao Li. > > > Bugs: MESOS-4735 > https://issues.apache.org/jira/browse/MESOS-4735 > > > Repository: mesos > > > Description > ------- > > Created URI.filename to name fetched files in sandbox where appropriate. > > > Diffs > ----- > > CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6 > docs/fetcher.md f70939d8410516c9387a8cba86b5b75539a5fe9a > include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b > include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b > src/launcher/fetcher.cpp f85b118fb19cf9d4563f89847a783be35067e815 > src/slave/containerizer/fetcher.hpp > bbdce88da6e41dbb88681bc9d604b00923033b3d > src/slave/containerizer/fetcher.cpp > 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161 > src/tests/fetcher_cache_tests.cpp 645dae208cb2b0aa2d2181d96eb1fd8893975430 > src/tests/fetcher_tests.cpp fb47706eb90ae5808bafe13c681d609a808b0c8e > > Diff: https://reviews.apache.org/r/45046/diff/ > > > Testing > ------- > > There are two paths by which a file gets fetched to the executor sandbox: the > without-cache path, where the fetcher downloads the file directly from the > specified URI, and the with-cache path, where it copies it from the cache. In > both cases, we verify that the file is saved to the sandbox directory with > the name specified by the "filename" field in the CommandInfo.URI proto. > > > Thanks, > > Michael Browning > >
