Hi Ben, thanks for the link. I had the feeling I saw this being discussed, but could not find the RR.
Cheers, Benjamin > On Mar 22, 2016, at 8:06 AM, Benjamin Mahler <bmah...@apache.org> wrote: > > Hey guys, we intentionally removed the ability to decrement Counters, please > see the context here on another recent patch: > https://reviews.apache.org/r/44473/ > > On Tue, Mar 22, 2016 at 12:00 AM, Benjamin Bannier > <benjamin.bann...@mesosphere.io> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45096/#review124745 > ----------------------------------------------------------- > > > > > 3rdparty/libprocess/include/process/metrics/counter.hpp (line 57) > <https://reviews.apache.org/r/45096/#comment187409> > > Could you add a post-decrement operator as well? It might not be as > useful as pre-decrement, but as this class provides post-increment this its > absence seems surprising. > > > > 3rdparty/libprocess/include/process/metrics/counter.hpp (line 78) > <https://reviews.apache.org/r/45096/#comment187407> > > Did you mean to use `fetch_sub` here? > > Do you plan to add unit tests for this class? > > > - Benjamin Bannier > > > On March 22, 2016, 7:42 a.m., fan du wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/45096/ > > ----------------------------------------------------------- > > > > (Updated March 22, 2016, 7:42 a.m.) > > > > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > > > > Bugs: MESOS-4981 > > https://issues.apache.org/jira/browse/MESOS-4981 > > > > > > Repository: mesos > > > > > > Description > > ------- > > > > Introduce 'minus' operator for class Counter. > > > > > > Diffs > > ----- > > > > 3rdparty/libprocess/include/process/metrics/counter.hpp > > a13cc7e18c8b23eae83c326d63874d9d2aaedc0d > > > > Diff: https://reviews.apache.org/r/45096/diff/ > > > > > > Testing > > ------- > > > > > > Thanks, > > > > fan du > > > > > >
