> On March 22, 2016, 4:46 p.m., Gilbert Song wrote: > > BTW, should we also add `utils.cpp` to `CMakeList.txt`?
Cmake support is going to need a lot more than that :-/ - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review124827 ----------------------------------------------------------- On March 22, 2016, 1:20 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44946/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 1:20 a.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-4828 > https://issues.apache.org/jira/browse/MESOS-4828 > > > Repository: mesos > > > Description > ------- > > Add utility functions to manipulate XFS project quotas. > > > Diffs > ----- > > src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf > src/slave/containerizer/mesos/isolators/disk/xfs/utils.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44946/diff/ > > > Testing > ------- > > Make check. Manual verification. Tests in subsequent patches. > > > Thanks, > > James Peach > >
