> On March 31, 2016, 10:12 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp, lines 366-368 > > <https://reviews.apache.org/r/44946/diff/11/?file=1318424#file1318424line366> > > > > In this method we can just validate the projectId first and then > > > > ``` > > traverse( > > path, > > std::bind(internal::setProjectId, > > lambda::_1, > > projectId, > > lambda::_2)); > > ```
The above wasn't indented correctly... ``` traverse( path, std::bind( internal::setProjectId, lambda::_1, projectId, lambda::_2)); ``` - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review126200 ----------------------------------------------------------- On March 30, 2016, 3:18 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44946/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 3:18 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-4828 > https://issues.apache.org/jira/browse/MESOS-4828 > > > Repository: mesos > > > Description > ------- > > Add utility functions to manipulate XFS project quotas. > > > Diffs > ----- > > src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 > src/slave/containerizer/mesos/isolators/xfs/utils.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/xfs/utils.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44946/diff/ > > > Testing > ------- > > Make check. Manual verification. Tests in subsequent patches. > > > Thanks, > > James Peach > >