----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45183/#review124961 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 156 - 162) <https://reviews.apache.org/r/45183/#comment187668> Can we move this logic to L134-L152? src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 207) <https://reviews.apache.org/r/45183/#comment187672> s/containerConfig.rootfs()/rootfs src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 216 - 222) <https://reviews.apache.org/r/45183/#comment187673> This was already checked in L194-L197, why check again here? - Guangya Liu On 三月 23, 2016, 12:20 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45183/ > ----------------------------------------------------------- > > (Updated 三月 23, 2016, 12:20 a.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy > Chen. > > > Bugs: MESOS-3003 > https://issues.apache.org/jira/browse/MESOS-3003 > > > Repository: mesos > > > Description > ------- > > Implemented mounting host system config files to container. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/runtime.hpp > 90179119ef297855091dad3fe969aa79810bf209 > src/slave/containerizer/mesos/isolators/docker/runtime.cpp > f97a9a92895387a9d504810a2ae971cfb5d3dbb4 > > Diff: https://reviews.apache.org/r/45183/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
