> On March 16, 2016, 11:08 p.m., Jie Yu wrote: > > This patch breaks all the ROOT DOCKER tests in our internal CI. I've > > reverted it for now. Can you do a sudo make check with docker? > > Steve Niemitz wrote: > ok, I see what the problem is here. The issue is with the > mesos-docker-executor code path (when launching a task w/ a TaskInfo, > launchExecutorProcess). Because the code path only waits for the > mesos-docker-executor process to launch, the inspect in update() fails since > the docker container hasn't launched yet. > > I'm not sure what the best solution is here, I'll play around with some > options. > > Steve Niemitz wrote: > Also, interestingly enough, if you remove the check in update() the > checks if the resources have changed, even without my patch it breaks because > the container isn't there yet, so this is even now just kind of accidentally > working.
Yeah, looks like the whole 'update' is problematic for the command task case. I'll think about that tomorrow to see if there is a clean solution. `docker->inspect` supports a retry interval (optional), basically, it'll wait until the container is up. But the problem with that is: if there is error in the executor, it'll wait forever. Maybe we could setup a timeout for that. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review123945 ----------------------------------------------------------- On March 16, 2016, 8:10 p.m., Steve Niemitz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33174/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 8:10 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-2617 > https://issues.apache.org/jira/browse/MESOS-2617 > > > Repository: mesos > > > Description > ------- > > Fix for docker containerizer not configuring CFS quotas correctly. > > It would be nice to refactor all this isolation code in a way that can be > shared between all containerizers, as this is basically just copied from the > CgroupsCpushareIsolator, but that's a much bigger undertaking. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 79cd955e9c241becff52cc4bbef81dcc16802ee7 > src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 > > Diff: https://reviews.apache.org/r/33174/diff/ > > > Testing > ------- > > > Thanks, > > Steve Niemitz > >