> On March 16, 2016, 4:22 a.m., Benjamin Bannier wrote: > > src/launcher/executor.cpp, lines 470-471 > > <https://reviews.apache.org/r/44499/diff/1/?file=1291043#file1291043line470> > > > > Any reason we cannot use the `CHECK` condition for the `if`?
Thanks, Benjamin! We do not always have taskEnvironment passed form runtime isolator, so it is not always ture. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44499/#review123854 ----------------------------------------------------------- On March 24, 2016, 2:53 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44499/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 2:53 p.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy > Chen. > > > Bugs: MESOS-4781 > https://issues.apache.org/jira/browse/MESOS-4781 > > > Repository: mesos > > > Description > ------- > > Added task_environment flag/used execvpe for command executor. > > > Diffs > ----- > > src/launcher/executor.cpp 4e9b4d9820f7c2f4cb1b3e16e2f4c8c13500693f > > Diff: https://reviews.apache.org/r/44499/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
