----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44499/#review125506 -----------------------------------------------------------
src/launcher/executor.cpp (line 311) <https://reviews.apache.org/r/44499/#comment188316> Just a question here: Does the os::raw::environment() will be overwritten by taskEnvironment? What is the use of `os::raw::environment()` here? - Guangya Liu On 三月 24, 2016, 9:53 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44499/ > ----------------------------------------------------------- > > (Updated 三月 24, 2016, 9:53 p.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy > Chen. > > > Bugs: MESOS-4781 > https://issues.apache.org/jira/browse/MESOS-4781 > > > Repository: mesos > > > Description > ------- > > Added task_environment flag/used execvpe for command executor. > > > Diffs > ----- > > src/launcher/executor.cpp 4e9b4d9820f7c2f4cb1b3e16e2f4c8c13500693f > > Diff: https://reviews.apache.org/r/44499/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
