----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45419/#review126078 -----------------------------------------------------------
Fix it, then Ship it! src/module/manager.hpp (line 35) <https://reviews.apache.org/r/45419/#comment188982> Could you also include `stout/nothing.hpp` here? src/module/manager.cpp (line 35) <https://reviews.apache.org/r/45419/#comment188983> My bad, `stout/stringify.hpp` was actually used here. - Benjamin Bannier On March 29, 2016, 5:41 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45419/ > ----------------------------------------------------------- > > (Updated March 29, 2016, 5:41 p.m.) > > > Review request for mesos, Benjamin Bannier and Kapil Arya. > > > Repository: mesos > > > Description > ------- > > Removes unused includes and usings from the ModuleManager. > > > Diffs > ----- > > src/module/manager.hpp 9944af0 > src/module/manager.cpp 8c9aaf7 > > Diff: https://reviews.apache.org/r/45419/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
