----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126388 -----------------------------------------------------------
Fix it, then Ship it! Ship It! src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 786) <https://reviews.apache.org/r/45546/#comment189379> Shouldn't we return a failure? src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 790) <https://reviews.apache.org/r/45546/#comment189380> Maybe s/netInfo/_networkInfo - Avinash sridharan On March 31, 2016, 2:55 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45546/ > ----------------------------------------------------------- > > (Updated March 31, 2016, 2:55 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented status() method of "network/cni" isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 1c8e231813c0579b79681c5d18b1f799a727ead7 > > Diff: https://reviews.apache.org/r/45546/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
