> On March 31, 2016, 6:31 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 786 > > <https://reviews.apache.org/r/45546/diff/1/?file=1320825#file1320825line786> > > > > Shouldn't we return a failure? > > Qian Zhang wrote: > I think we should not return a failure because there can be some > containers do not want to opt in CNI networks.
I see your point. Looks like we are not storing container information for containers that are not connected to a CNI network. This behavior is different compared to other isolators (they store container information for all containers). We should definitely add a comment here explaining this behavior. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126388 ----------------------------------------------------------- On April 1, 2016, 2:17 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45546/ > ----------------------------------------------------------- > > (Updated April 1, 2016, 2:17 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4764 > https://issues.apache.org/jira/browse/MESOS-4764 > > > Repository: mesos > > > Description > ------- > > Implemented status() method of "network/cni" isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 3a07540909ed771d1bd3b22888e04d5fb451710d > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 486c382365d5293cd9d53b8b239f70a543c46792 > > Diff: https://reviews.apache.org/r/45546/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
