> On April 1, 2016, 7:27 a.m., Jiang Yan Xu wrote: > > src/tests/containerizer/xfs_quota_tests.cpp, line 71 > > <https://reviews.apache.org/r/44947/diff/11/?file=1320117#file1320117line71> > > > > We have > > > > `makeQuotaInfo` vs. `mkfile` & `mkloop`. Can we make the use of the > > word `make` or `mk` consistent? Generally we avoid abbreviations so using > > `make` (and camelCasing) is preferred.
``mkfile`` and ``mkloop`` are named after ``mkfile(1)``, ``mknod(1)``, etc. I expected that would be a fairly familiar nomenclature. ``makeQuotaInfo`` is substantially different so there's no good reason to use the same naming scheme. It is following the ``std::make_pair`` pattern, but using Mesos naming conventions. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/#review126334 ----------------------------------------------------------- On April 1, 2016, midnight, James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44947/ > ----------------------------------------------------------- > > (Updated April 1, 2016, midnight) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-4828 > https://issues.apache.org/jira/browse/MESOS-4828 > > > Repository: mesos > > > Description > ------- > > Add tests for XFS project quota utilities. > > > Diffs > ----- > > src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 > src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 > src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION > src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3 > > Diff: https://reviews.apache.org/r/44947/diff/ > > > Testing > ------- > > Make check. Manual testing. These tests. > > > Thanks, > > James Peach > >
