----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/#review127261 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/xfs_quota_tests.cpp (line 154) <https://reviews.apache.org/r/44947/#comment190551> Methods inside a class should be separated by one blank line. Here and below. src/tests/containerizer/xfs_quota_tests.cpp (line 163) <https://reviews.apache.org/r/44947/#comment190482> We changed this to "xfs/disk". Strictly speaking this belongs to <https://reviews.apache.org/r/44949/> as it's not used here. src/tests/containerizer/xfs_quota_tests.cpp (line 215) <https://reviews.apache.org/r/44947/#comment190548> Move this one to the bottom as it is the most complex test. src/tests/containerizer/xfs_quota_tests.cpp (lines 271 - 282) <https://reviews.apache.org/r/44947/#comment190550> These checks are not related to the rest of the test above and should be in a separate test. Maybe ``` TEST_F(ROOT_XFS_QuotaTest, ProjectIdErrors) { } ``` It can be the placed at the top as the first test. src/tests/containerizer/xfs_quota_tests.cpp (line 306) <https://reviews.apache.org/r/44947/#comment190547> Add a check that expects mkfile() to return an error when it goes past the limit. - Jiang Yan Xu On April 5, 2016, 4:40 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44947/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 4:40 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-4828 > https://issues.apache.org/jira/browse/MESOS-4828 > > > Repository: mesos > > > Description > ------- > > Add tests for XFS project quota utilities. > > > Diffs > ----- > > src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 > src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION > src/tests/environment.cpp 2afaa328a0fb226a2d1ca35a4754ccb274bc075d > > Diff: https://reviews.apache.org/r/44947/diff/ > > > Testing > ------- > > Make check. Manual testing. These tests. > > > Thanks, > > James Peach > >