----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126754 -----------------------------------------------------------
Ship it! Thanks Yong! Patch looks great now. The only thing I'd change at this point is the wording in the commit message. Probably something like: ``` Add a commit hook for checking non-printable characters (MESOS-4033). This patch adds an addition check in mesos-style.pl to check for non-printable characters. It scans .cpp, .hpp, .cc, .h files and reports an error if non-printable characters exist. As part of this patch, two non-printable characters have been identified in versioning.md (one in Line 85 and another in Line 96) and are corrected accordingly. Note: Scanning .md files is skipped based on feedback from reviews. Note: This commit includes patches from Kevin Klues and haosdent. ``` Thanks! - Kevin Klues On April 3, 2016, 8:36 p.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > ----------------------------------------------------------- > > (Updated April 3, 2016, 8:36 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd > Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi > Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > ------- > > This review request tries to add addition check in mesos-style.pl > for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h > files and report error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > Note: .md scan is skipped based on feedback from review request. > > Note: This commit includes patches from Kevin Klues and haosdent. > > > Diffs > ----- > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > ------- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
