> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 120 > > <https://reviews.apache.org/r/45033/diff/8/?file=1323577#file1323577line120> > > > > It would be great if we could `+ 1` the `chars` here like we already > > do for the `line_number` in order to keep this all in one place. We could > > also use this opportunity to go for less incidental list formatting, e.g., > > > > chars=', '.join([str(char + 1) for char in char_errors]) # gives > > e.g., "Line: 10, Chars: 1, 2, 3: <rest of line here> > > Yong Tang wrote: > Thanks Benjamin. In Ln 112 the "+ 1" of the Chars has already been > processed ("offset + 1"). > > Benjamin Bannier wrote: > Exactly! My point was that I wasn't sure that doing these operations on > `line_numer` and `char_errors` in different operations helped clarity. > > Yong Tang wrote: > Oh I see. Let me update the review request.
Thanks for the review Benjamin. The review request has been updated. Let me know if there are any other issues. - Yong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126806 ----------------------------------------------------------- On April 4, 2016, 3:21 p.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 3:21 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd > Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi > Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > ------- > > This patch adds an addition check in mesos-style.pl to check > for non-printable characters. It scans .cpp, .hpp, .cc, .h > files and reports an error if non-printable characters exist. > > As part of this patch, two non-printable characters have been identified > in versioning.md (one in Line 85 and another in Line 96) and are corrected > accordingly. > > Note: Scanning .md files is skipped based on feedback from reviews. > > Note: This commit includes patches from Kevin Klues and haosdent. > > > Diffs > ----- > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > ------- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
