----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45983/#review128026 -----------------------------------------------------------
Patch looks great! Reviews applied: [45953, 45954, 45955, 45956, 45983] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 10, 2016, 4:32 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45983/ > ----------------------------------------------------------- > > (Updated April 10, 2016, 4:32 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-5160 > https://issues.apache.org/jira/browse/MESOS-5160 > > > Repository: mesos > > > Description > ------- > > Enabled the `network/cni` isolator in `MesosContainerizer`. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > a5dd22380066aa85de04d485052084e2629681c0 > > Diff: https://reviews.apache.org/r/45983/diff/ > > > Testing > ------- > > make > > * Ran the Agent without the `network/cni` enabled in the `--isolation` flags. > Without the `--network_cni_plugins_dir` and the `--network_cni_config_dir`, > container using a docker image was launched on the host-network. With the > `--network_cni_plugins_dir` and the `--network_cni_config_dir` specified the > CNI network isolator correctly invoked the specified plugin to given the > container its own network namespace. > > > Thanks, > > Avinash sridharan > >
