----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45983/#review128811 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp (lines 165 - 168) <https://reviews.apache.org/r/45983/#comment192265> Please wrap this with ifdef linux - Jie Yu On April 13, 2016, 2:19 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45983/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 2:19 p.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-5130 > https://issues.apache.org/jira/browse/MESOS-5130 > > > Repository: mesos > > > Description > ------- > > Enabled the `network/cni` isolator in `MesosContainerizer`. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > c25fa92d2a5fa9c828e77c3c0f8b1f795d1b8440 > > Diff: https://reviews.apache.org/r/45983/diff/ > > > Testing > ------- > > make > > * Ran the Agent without the `network/cni` enabled in the `--isolation` flags. > Without the `--network_cni_plugins_dir` and the `--network_cni_config_dir`, > container using a docker image was launched on the host-network. With the > `--network_cni_plugins_dir` and the `--network_cni_config_dir` specified the > CNI network isolator correctly invoked the specified plugin to given the > container its own network namespace. > > > Thanks, > > Avinash sridharan > >