> On April 12, 2016, 2:37 p.m., Joris Van Remoortere wrote: > > There is no JIRA for this. > > Initializing the winsock system seems like functionality that belongs in a > > helper function rather than inside a test? > > How is libprocess going to initialize it? What about mesos? > > I'm guessing we'll want to have something like: > > ``` > > Try<Nothing> winsock_initialize = winsock_initialize(); > > ... > > ``` > > > > and do this in `libprocess::initialize()` > > > > Thoughts?
This should likely be wrapped in the constructor of a class, while WSACleanup should be called from the destructor. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/#review128410 ----------------------------------------------------------- On April 11, 2016, 8:28 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46008/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 8:28 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > ------- > > Stout: Initialize Windows socket stack in Stout tests. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/main.cpp > c449de87bede4d3bf1df368eaf1d22f857c2298f > > Diff: https://reviews.apache.org/r/46008/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
