-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45326/#review128941
-----------------------------------------------------------




src/slave/flags.cpp (line 803)
<https://reviews.apache.org/r/45326/#comment192393>

    Just leave a concern here:
    
    Do we always have dvdcli installed in `/usr/bin` for all os (e.g., centos)? 
any special case?


- Gilbert Song


On April 13, 2016, 11:06 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45326/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 11:06 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5084
>     https://issues.apache.org/jira/browse/MESOS-5084
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added agent flag dvdcli_dir for specify dvdcli path.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md ce51f26f0584eeecb5c96e39a5bcc21f5906a29c 
>   src/slave/flags.hpp ee520acc459564fe68272950948fc80c5e24513a 
>   src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86 
> 
> Diff: https://reviews.apache.org/r/45326/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to