----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/#review128743 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp (line 64) <https://reviews.apache.org/r/45326/#comment192208> should we verify that the dvdcli binary actually exists here (and if not generate an error)? - James DeFelice On April 2, 2016, 3:54 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45326/ > ----------------------------------------------------------- > > (Updated April 2, 2016, 3:54 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added agent flag dvdcli_dir for specify dvdcli path. > > > Diffs > ----- > > docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 > src/slave/constants.hpp 449c8cd9f43f71b4612023eb463969e9db0bc960 > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION > src/slave/flags.hpp d0c606eea74e1a2e69067c43a267047e65a22a04 > src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 > > Diff: https://reviews.apache.org/r/45326/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >