> On April 12, 2016, 3:09 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/env_tests.cpp, lines 26-27 > > <https://reviews.apache.org/r/46009/diff/1/?file=1339066#file1339066line26> > > > > Please use plain names that are self descriptive. > > Alex Clemmer wrote: > I'm not sure whether you're talking about the symbol `key` or the string > that is its value so I made the first more descriptive and the second more > boring. Christmas comes early to the Van Remoortere household!
How about: ``` string key = "key"; string value = "value"; string new_value = "new_value"; ``` - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46009/#review128420 ----------------------------------------------------------- On April 13, 2016, 10:05 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46009/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 10:05 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > ------- > > Stout:[1/2] Added simple tests for `os::` functions. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 400c6dc451602926f93b22713af8c66d7ca59ca6 > 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt > c9d331df2f4496183b5734d2434413f68b9c1b4b > 3rdparty/libprocess/3rdparty/stout/tests/os/env_tests.cpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os/strerror_tests.cpp > d5a96ad6b8b1c09b4f016e0c8e3e5c5672b55ef3 > > Diff: https://reviews.apache.org/r/46009/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >