> On April 14, 2016, 8:17 p.m., Greg Mann wrote: > >
Could you fix the typo in the commit message: "protobut" should be "protobuf". Also, could you remove the duplicate Summary that's in the Description field, and add a more verbose description of the patch in the Description field? - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review128971 ----------------------------------------------------------- On April 14, 2016, 4:41 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45270/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 4:41 a.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Added spec protobut for external mount. > > > Diffs > ----- > > src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 > src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f > src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/volume/spec.proto > PRE-CREATION > > Diff: https://reviews.apache.org/r/45270/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >