----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46114/#review129041 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp (lines 5945 - 5948) <https://reviews.apache.org/r/46114/#comment192501> can you use a ternary operator here instead? - Vinod Kone On April 14, 2016, 3:34 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46114/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 3:34 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3923 > https://issues.apache.org/jira/browse/MESOS-3923 > > > Repository: mesos > > > Description > ------- > > Use the `principal` set in `FrameworkInfo.principal` to populate > framework metrics instead of looking them up in `authenticated` > map. It also ensures that HTTP->PID framework downgrades preserve > the metrics and no additional logic is needed to deal with this. > (Previously HTTP frameworks never had AuthN and no principal was > passed in `FrameworkInfo`, so this was never a concern). > > > Diffs > ----- > > src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c > > Diff: https://reviews.apache.org/r/46114/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
