----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46114/ -----------------------------------------------------------
(Updated April 15, 2016, 4:35 p.m.) Review request for mesos and Vinod Kone. Changes ------- Review comments from Vinod Bugs: MESOS-3923 https://issues.apache.org/jira/browse/MESOS-3923 Repository: mesos Description ------- Use the `principal` set in `FrameworkInfo.principal` to populate framework metrics instead of looking them up in `authenticated` map. It also ensures that HTTP->PID framework downgrades preserve the metrics and no additional logic is needed to deal with this. (Previously HTTP frameworks never had AuthN and no principal was passed in `FrameworkInfo`, so this was never a concern). Diffs (updated) ----- src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c Diff: https://reviews.apache.org/r/46114/diff/ Testing ------- make check Thanks, Anand Mazumdar