----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46249/#review129478 -----------------------------------------------------------
Patch looks great! Reviews applied: [46249] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 19, 2016, 2:52 a.m., Andy Pang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46249/ > ----------------------------------------------------------- > > (Updated April 19, 2016, 2:52 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, Joseph Wu, Niklas Nielsen, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > If we in hook/module manager use libprocess library, > it will auto use process initialize fucntion, > as the process::initialize will only call once, > then in the main fucnton process initialize > process::initialize("master") will not be called. > So the HTTP request process "delegate" will be wrong, > http request will not be response. > > > Diffs > ----- > > src/master/main.cpp 7bbc982 > > Diff: https://reviews.apache.org/r/46249/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Andy Pang > >