----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46249/#review129446 -----------------------------------------------------------
Ship it! LGTM. src/master/main.cpp (lines 242 - 249) <https://reviews.apache.org/r/46249/#comment192858> NOTE: This is technically not necessary for modules, since `ModuleManager::load` does not execute any dynamically loaded code. It's still nice to have, since it makes sense to do `process::initialize` immediately after loading flags. - Joseph Wu On April 18, 2016, 7:52 p.m., Andy Pang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46249/ > ----------------------------------------------------------- > > (Updated April 18, 2016, 7:52 p.m.) > > > Review request for mesos, Adam B, Kapil Arya, Joseph Wu, Niklas Nielsen, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > If we in hook/module manager use libprocess library, > it will auto use process initialize fucntion, > as the process::initialize will only call once, > then in the main fucnton process initialize > process::initialize("master") will not be called. > So the HTTP request process "delegate" will be wrong, > http request will not be response. > > > Diffs > ----- > > src/master/main.cpp 7bbc982 > > Diff: https://reviews.apache.org/r/46249/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Andy Pang > >
