----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review129968 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 331 - 333) <https://reviews.apache.org/r/45375/#comment193545> Please add ``` VLOG(1) << "Ignoring cleanup request for unknown container: " << containerId;``` src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 338) <https://reviews.apache.org/r/45375/#comment193547> ditto. src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 339) <https://reviews.apache.org/r/45375/#comment193548> ditto. src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 342) <https://reviews.apache.org/r/45375/#comment193549> const string src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 345) <https://reviews.apache.org/r/45375/#comment193550> add `!`. src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 360) <https://reviews.apache.org/r/45375/#comment193611> const string src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 368) <https://reviews.apache.org/r/45375/#comment193551> ditto. src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 378 - 380) <https://reviews.apache.org/r/45375/#comment193614> Seems like we should capture the first `:` here. Otherwise, we have to document that users should not include any `:` in a volume name. src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 399 - 408) <https://reviews.apache.org/r/45375/#comment193616> ditto. src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 420) <https://reviews.apache.org/r/45375/#comment193618> Will `container directory` be confused? - Gilbert Song On April 20, 2016, 8:43 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45375/ > ----------------------------------------------------------- > > (Updated April 20, 2016, 8:43 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Implemented cleanup() for docker volume isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp > bedc687cc280d0b721fb84801039fd3614364cca > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > 915e5ae755a55a02b7dfcda88165f27346cad955 > > Diff: https://reviews.apache.org/r/45375/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >