----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46580/#review130179 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/3rdparty/Makefile.am (line 74) <https://reviews.apache.org/r/46580/#comment193867> Can you fix the tailing `\` alignment? 3rdparty/libprocess/Makefile.am (lines 189 - 191) <https://reviews.apache.org/r/46580/#comment193863> Not yours, but I don't know why those are needed. 3rdparty/libprocess/Makefile.am (lines 215 - 217) <https://reviews.apache.org/r/46580/#comment193864> Ditto. 3rdparty/libprocess/configure.ac (line 892) <https://reviews.apache.org/r/46580/#comment193866> Is this some specicial autoconf thing? I don't see it being used... - Jie Yu On April 22, 2016, 7:24 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46580/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 7:24 p.m.) > > > Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy > Varghese. > > > Bugs: MESOS-5254 > https://issues.apache.org/jira/browse/MESOS-5254 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am f7aa579 > 3rdparty/libprocess/3rdparty/uriparser-0.8.4.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/versions.am 5506eb3 > 3rdparty/libprocess/Makefile.am c51c31e > 3rdparty/libprocess/configure.ac d27e46e > > Diff: https://reviews.apache.org/r/46580/diff/ > > > Testing > ------- > > ../configure > make > make check > > > Thanks, > > Joseph Wu > >
