> On 四月 24, 2016, 7:02 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, lines > > 65-70 > > <https://reviews.apache.org/r/45370/diff/11/?file=1358422#file1358422line65> > > > > Also, I realized that we don't need this struct. We just need the mount > > targets in `_prepare()`. > > Jie Yu wrote: > I'll make the change for you. > > Jie Yu wrote: > In fact, I'll move it to the cpp file. I don't think we need it in the > header.
Yes, moving it to cpp file may be better, but we still need to construct it in `prepare` and use it in `_prepare`. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review130287 ----------------------------------------------------------- On 四月 23, 2016, 7:06 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45370/ > ----------------------------------------------------------- > > (Updated 四月 23, 2016, 7:06 a.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Implemented prepare() for volume isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp > bedc687cc280d0b721fb84801039fd3614364cca > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > 915e5ae755a55a02b7dfcda88165f27346cad955 > src/slave/containerizer/mesos/isolators/docker/volume/state.hpp > bc0c3299f9f3e351aaa20652b784bccbfd40c1a5 > > Diff: https://reviews.apache.org/r/45370/diff/ > > > Testing > ------- > > make > make check > > Will update `Sequence` later. > > > Thanks, > > Guangya Liu > >
