> On 四月 24, 2016, 6:29 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 174-188 > > <https://reviews.apache.org/r/45370/diff/11/?file=1358423#file1358423line174> > > > > Let's not create any side effect at this moment. Let's do that after > > creating the checkpoint. Also, don't you need to do mkdir for containerPath > > if rootfs is not used? > > Jie Yu wrote: > I'll make the change for you. > > Guangya Liu wrote: > +1 to create the mount point after checkpoint succeed.
It may not that straightforward to update the logic here, the current logic in prepare() is as this: 1) traverse all volumes, create the checkpoint volume hashset and vector volumeInfo, voluemInfo including containerPath, DockerVolume and mount options. 2) checkpoint the hashset volume. If want to create the the containerPath after creating the checkpoint, then we may need to travse all volumes again to generate the containerPath and then create the containerPath. So my thinking for the logic change is that: 1) In `prepare`, traverse all volumes and only generate the checkpoint hashset volume list. 2) Checkpoint the volumes. 3) In `_prepare`, may need add a new parameter `ExecutorInfo`, then in `_prepare`, travrse all the volumes again to get containerPath. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review130286 ----------------------------------------------------------- On 四月 23, 2016, 7:06 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45370/ > ----------------------------------------------------------- > > (Updated 四月 23, 2016, 7:06 a.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Implemented prepare() for volume isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp > bedc687cc280d0b721fb84801039fd3614364cca > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > 915e5ae755a55a02b7dfcda88165f27346cad955 > src/slave/containerizer/mesos/isolators/docker/volume/state.hpp > bc0c3299f9f3e351aaa20652b784bccbfd40c1a5 > > Diff: https://reviews.apache.org/r/45370/diff/ > > > Testing > ------- > > make > make check > > Will update `Sequence` later. > > > Thanks, > > Guangya Liu > >
