> On April 29, 2016, 9:32 a.m., Greg Mann wrote: > > 3rdparty/libprocess/src/process.cpp, line 989 > > <https://reviews.apache.org/r/46806/diff/1/?file=1365190#file1365190line989> > > > > I'm guessing this refers to `new Route("/__processes__", None(), > > __processes__);`? I think it might be helpful to use a more obvious name. > > Or perhaps referencing the `process_route` name in a comment above the > > `Route()` statement would do the trick?
Renamed to `processesRoute`. One of Neil's patches will give that process a name (to fix the memory leak): https://reviews.apache.org/r/45995/ - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46806/#review131120 ----------------------------------------------------------- On May 2, 2016, 10:50 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46806/ > ----------------------------------------------------------- > > (Updated May 2, 2016, 10:50 a.m.) > > > Review request for mesos, Greg Mann, Joerg Schad, Joris Van Remoortere, and > Kapil Arya. > > > Bugs: MESOS-5304 > https://issues.apache.org/jira/browse/MESOS-5304 > > > Repository: mesos > > > Description > ------- > > Moves `metrics::initialize` below the creation of the `help` process. > > Adds a comment block to explain the ordering of process creation in > `process::initialize`. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > dcaa64633d1eea330649c563635642928164d73c > > Diff: https://reviews.apache.org/r/46806/diff/ > > > Testing > ------- > > make check > > Also double-checked that `/help/metrics/snapshot` shows up on both master and > agent. > > > Thanks, > > Joseph Wu > >
