----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46806/#review131347 -----------------------------------------------------------
Patch looks great! Reviews applied: [46806] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 2, 2016, 5:50 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46806/ > ----------------------------------------------------------- > > (Updated May 2, 2016, 5:50 p.m.) > > > Review request for mesos, Greg Mann, Joerg Schad, Joris Van Remoortere, and > Kapil Arya. > > > Bugs: MESOS-5304 > https://issues.apache.org/jira/browse/MESOS-5304 > > > Repository: mesos > > > Description > ------- > > Moves `metrics::initialize` below the creation of the `help` process. > > Adds a comment block to explain the ordering of process creation in > `process::initialize`. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > dcaa64633d1eea330649c563635642928164d73c > > Diff: https://reviews.apache.org/r/46806/diff/ > > > Testing > ------- > > make check > > Also double-checked that `/help/metrics/snapshot` shows up on both master and > agent. > > > Thanks, > > Joseph Wu > >
