----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/#review132731 -----------------------------------------------------------
src/docker/executor.hpp (line 27) <https://reviews.apache.org/r/47205/#comment196980> `#include <stout/error.hpp>` src/docker/executor.hpp (line 74) <https://reviews.apache.org/r/47205/#comment196977> Just as a note, since you call `add` with `&task_environment` instead of `&Flags::task_environment` you explicitly (and consistently with the other invocations here) select an overload of `FlagsBase::add` which will make this class non-copyable, see MESOS-3335. This will need to be cleaned up as part of MESOS-3335. src/docker/executor.hpp (line 120) <https://reviews.apache.org/r/47205/#comment196978> Any reason we wouldn't use an unordered map like e.g., a stout `hashmap` here and as function argument elsewhere in this patch? src/docker/executor.cpp (line 502) <https://reviews.apache.org/r/47205/#comment196979> stout `hashmap`? - Benjamin Bannier On May 11, 2016, 8:56 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47205/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 8:56 p.m.) > > > Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya. > > > Bugs: MESOS-5350 > https://issues.apache.org/jira/browse/MESOS-5350 > > > Repository: mesos > > > Description > ------- > > This flag opens up a way for hooks to specify environment variables for > docker tasks. Existing hooks can only affect the environment variables > of docker executors. > > > Diffs > ----- > > src/docker/executor.hpp 798ca3d4e261854a3b911d59929f2ca2afeb9ac8 > src/docker/executor.cpp d60addcbe4a1869945ce42f4bb4b1e80e3f29f19 > > Diff: https://reviews.apache.org/r/47205/diff/ > > > Testing > ------- > > See later reviews in chain. > > > Thanks, > > Joseph Wu > >
