----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/#review134882 -----------------------------------------------------------
src/docker/executor.hpp (line 89) <https://reviews.apache.org/r/47205/#comment199825> kill this line. In fact, I would reorder and move the one that's being deprecated to the end. src/docker/executor.hpp (line 90) <https://reviews.apache.org/r/47205/#comment199826> Can this be `Option<JSON::Object>`? src/docker/executor.cpp (line 680) <https://reviews.apache.org/r/47205/#comment199828> json->values src/docker/executor.cpp (line 685) <https://reviews.apache.org/r/47205/#comment199830> I would align `<<` with the `<<` above. - Jie Yu On May 24, 2016, 9:02 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47205/ > ----------------------------------------------------------- > > (Updated May 24, 2016, 9:02 p.m.) > > > Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya. > > > Bugs: MESOS-5350 > https://issues.apache.org/jira/browse/MESOS-5350 > > > Repository: mesos > > > Description > ------- > > This flag opens up a way for hooks to specify environment variables for > docker tasks. Existing hooks can only affect the environment variables > of docker executors. > > > Diffs > ----- > > src/docker/executor.hpp 798ca3d4e261854a3b911d59929f2ca2afeb9ac8 > src/docker/executor.cpp 04f44044a80e1b355580ee3d1d8d301ac3baf565 > > Diff: https://reviews.apache.org/r/47205/diff/ > > > Testing > ------- > > See later reviews in chain. > > > Thanks, > > Joseph Wu > >
