----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47864/#review134871 -----------------------------------------------------------
Fix it, then Ship it! Update the ordering and the comment, and I'm ready to ship it! include/mesos/authorizer/authorizer.proto (line 34) <https://reviews.apache.org/r/47864/#comment199820> "The `Object` for a particular request action is described by either its string value or various metadata Info." include/mesos/authorizer/authorizer.proto (lines 40 - 43) <https://reviews.apache.org/r/47864/#comment199816> I'd suggest we reorder these: FrameworkInfo, ExecutorInfo, TaskInfo, then Task. - Adam B On May 25, 2016, 4:15 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47864/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 4:15 p.m.) > > > Review request for mesos, Adam B, Joerg Schad, and Michael Park. > > > Bugs: MESOS-5153 > https://issues.apache.org/jira/browse/MESOS-5153 > > > Repository: mesos > > > Description > ------- > > Adds optional fields to `authorization::Object` in order to allow > for complex authorization mechanisms. > > The fields are: > > - `FrameworkInfo` > - `TaskInfo` > - `ExecutorInfo` > > > Diffs > ----- > > include/mesos/authorizer/authorizer.proto > 911a2271211249a41c4467f6754e9996f640bf38 > > Diff: https://reviews.apache.org/r/47864/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >