> On May 24, 2016, 11:07 p.m., Joris Van Remoortere wrote: > > src/CMakeLists.txt, line 259 > > <https://reviews.apache.org/r/47469/diff/1/?file=1385659#file1385659line259> > > > > Why here as opposed to alphabetical?
In `CMakeLists.txt`, we have making them alphabetical by folder. So all of `a/b` and `a/z` come before `a/b/a`. > On May 24, 2016, 11:07 p.m., Joris Van Remoortere wrote: > > src/slave/containerizer/mesos/launch.cpp, lines 138-146 > > <https://reviews.apache.org/r/47469/diff/1/?file=1385660#file1385660line138> > > > > Are we gaining something specifically on the windows side here? > > Is this just mapping the FDs into an abstraction, or are we actually > > creating a pipe? > > If so, why wasn't that done before? The point of using a class was that I wanted to be able to think of a pipe as a pair of either `HANDLE`s or file descriptors. Daniel will be changing this review up a bit, so I will leave this here for posterity, but this code will probably change a bit. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47469/#review134656 ----------------------------------------------------------- On May 17, 2016, 4:02 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47469/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 4:02 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Bugs: MESOS-3624 > https://issues.apache.org/jira/browse/MESOS-3624 > > > Repository: mesos > > > Description > ------- > > Agent: Added `launch.cpp` to Windows build. > > > Diffs > ----- > > src/CMakeLists.txt e0c538d9e6542fbe279bfbf6f20172e4c611c859 > src/slave/containerizer/mesos/launch.cpp > e22106b014c871e2184a15c2ab154a0674874e47 > > Diff: https://reviews.apache.org/r/47469/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
