----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47469/#review135585 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/launch.cpp (lines 138 - 139) <https://reviews.apache.org/r/47469/#comment200618> I expanded on this comment a little. src/slave/containerizer/mesos/launch.cpp (lines 141 - 142) <https://reviews.apache.org/r/47469/#comment200617> we can re-use `pipe[0]` on the right hand side as well right? - Joris Van Remoortere On May 30, 2016, 10:08 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47469/ > ----------------------------------------------------------- > > (Updated May 30, 2016, 10:08 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Bugs: MESOS-3624 > https://issues.apache.org/jira/browse/MESOS-3624 > > > Repository: mesos > > > Description > ------- > > Agent: Added `launch.cpp` to Windows build. > > > Diffs > ----- > > src/CMakeLists.txt 577a17c584923959fdd79bc53eb998a62e30b728 > src/slave/containerizer/mesos/launch.cpp > e22106b014c871e2184a15c2ab154a0674874e47 > > Diff: https://reviews.apache.org/r/47469/diff/ > > > Testing > ------- > > OSX: make check > Windows: Build/run > > > Thanks, > > Alex Clemmer > >
