> On May 24, 2016, 11:22 p.m., Joris Van Remoortere wrote: > > src/slave/containerizer/fetcher.cpp, lines 210-211 > > <https://reviews.apache.org/r/47472/diff/1/?file=1385675#file1385675line210> > > > > Why is this logic compiled out on windows? > > Does it not apply? If so, can we add a comment? > > If it does, but we can't implement it, can we add a `TODO` referencing > > a JIRA? > > If the issue is the slash separator, should we be using the new > > constant you introduced? `os::PATH_SEPARATOR`?
I rearranged the code somewhat so it's compatible. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47472/#review134659 ----------------------------------------------------------- On May 26, 2016, 2:23 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47472/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 2:23 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Bugs: MESOS-3618 > https://issues.apache.org/jira/browse/MESOS-3618 > > > Repository: mesos > > > Description > ------- > > Windows: Added support for `fetcher.cpp`. > > > Diffs > ----- > > src/slave/containerizer/fetcher.cpp > 176d8863d1becd8864218a0012ab45c614f0ad77 > > Diff: https://reviews.apache.org/r/47472/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
