----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47472/#review135586 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/fetcher.cpp (lines 224 - 225) <https://reviews.apache.org/r/47472/#comment200619> since the previous state is an error, we can use `if` as opposed to `else if` src/slave/containerizer/fetcher.cpp (line 336) <https://reviews.apache.org/r/47472/#comment200620> let's say something like "currently does not support fetching files from HDFS" - Joris Van Remoortere On May 29, 2016, 10:20 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47472/ > ----------------------------------------------------------- > > (Updated May 29, 2016, 10:20 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Bugs: MESOS-3618 > https://issues.apache.org/jira/browse/MESOS-3618 > > > Repository: mesos > > > Description > ------- > > Windows: Added support for `fetcher.cpp`. > > > Diffs > ----- > > src/slave/containerizer/fetcher.cpp > 176d8863d1becd8864218a0012ab45c614f0ad77 > > Diff: https://reviews.apache.org/r/47472/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
